Project

General

Profile

Bug #22922

Breaking Ground: [LandClassROC] Excessive Log Spam

Added by TonkaCrash almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Severity:
Normal
Assignee:
-
Category:
Application
Target version:
Start date:
06/17/2019
% Done:

100%

Version:
Platform:
Windows
Expansion:
Breaking Ground
Language:
English (US)
Mod Related:
No
Votes:
Arrow u r green
Arrow d r red

Description

I've got a ship in a equatorial Mun orbit just above 10,000m with a scanner arm attached, yet my log is filling with update messages from what I guess is a module related to the new surface features. Normally when I see mods spitting out messages at this rate I download the mod, comment out the logging and usually see a performance improvement.

I watch the console window quite frequently to look for mod bugs, but this makes that very difficult in this situation.

1) Why am I seeing these messages at all?
2) Why am I seeing them at a range where surface features are not at all visible?
3) I am in equatorial orbit above the Min Safe Altitude of the Mun. Can whatever process that causes this be optimized to not occur in this situation?

[[https://www.dropbox.com/s/u6nav7j6dqkgrzi/KSP.Log_ROC_Spam.zip?dl=0]]

For example this is one block, the frequecy varies, from every 5 to 20 seconds.

[LOG 12:29:17.881] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.881] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.881] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.881] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.881] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.881] [LandClassROC]: Quad Mun Zn30110010 Area 1.164365 KM^2 Create 6 MunStone
[LOG 12:29:17.881] [LandClassROC]: ROC munCrater(Clone) after rotation height = 1.162161
[LOG 12:29:17.881] [LandClassROC]: Quad Mun Zn30110010 Area 1.164365 KM^2 Create 1 MunCrater
[LOG 12:29:17.882] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.882] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.882] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.882] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.882] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.882] [LandClassROC]: Quad Mun Zn30110011 Area 1.164365 KM^2 Create 5 MunStone
[LOG 12:29:17.882] [LandClassROC]: ROC munCrater(Clone) after rotation height = 1.162161
[LOG 12:29:17.882] [LandClassROC]: Quad Mun Zn30110011 Area 1.164365 KM^2 Create 1 MunCrater
[LOG 12:29:17.882] [LandClassROC]: ROC munLargeCrater(Clone) after rotation height = 3.197291
[LOG 12:29:17.882] [LandClassROC]: Quad Mun Zn30110011 Area 1.164365 KM^2 Create 1 MunLargeCrater
[LOG 12:29:17.883] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.883] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.883] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.883] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.883] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.883] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.883] [LandClassROC]: Quad Mun Zn30110012 Area 1.164365 KM^2 Create 6 MunStone
[LOG 12:29:17.883] [LandClassROC]: ROC munCrater(Clone) after rotation height = 1.162161
[LOG 12:29:17.883] [LandClassROC]: Quad Mun Zn30110012 Area 1.164365 KM^2 Create 1 MunCrater
[LOG 12:29:17.883] [LandClassROC]: ROC munLargeCrater(Clone) after rotation height = 3.197291
[LOG 12:29:17.884] [LandClassROC]: Quad Mun Zn30110012 Area 1.164365 KM^2 Create 1 MunLargeCrater
[LOG 12:29:17.884] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.884] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.884] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.884] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.884] [LandClassROC]: ROC munStone(Clone) after rotation height = 0.6012534
[LOG 12:29:17.884] [LandClassROC]: Quad Mun Zn30110013 Area 1.164365 KM^2 Create 5 MunStone
[LOG 12:29:17.884] [LandClassROC]: ROC munCrater(Clone) after rotation height = 1.162161
[LOG 12:29:17.884] [LandClassROC]: Quad Mun Zn30110013 Area 1.164365 KM^2 Create 1 MunCrate

History

#1 Updated by diomedea almost 2 years ago

  • Category changed from Bug Tracker to Application
  • Status changed from New to Confirmed
  • Severity changed from Low to Normal
  • % Done changed from 0 to 10

Well, yes, you have a good point.
LandClassROC logging was introduced during development as a tool for testing the surface features placement. Tests had to keep being done until very late, but were completed for 1.7.2
There's no more need now to have those messages logged, while (as you correctly hinted) they bring to a performance drop.

#3 Updated by chris.fulton almost 2 years ago

  • Status changed from Confirmed to Ready to Test
  • Target version set to 1.7.3
  • % Done changed from 10 to 80

Several Changes and bug fixes have been made, moving this bug to RTT and can you check it in 1.7.3.2594?

#4 Updated by TonkaCrash almost 2 years ago

chris.fulton wrote:

Several Changes and bug fixes have been made, moving this bug to RTT and can you check it in 1.7.3.2594?

This is fixed, I no longer see these messages in 1.7.3.2594.

#5 Updated by Anth12 about 1 year ago

  • Status changed from Ready to Test to Resolved
  • % Done changed from 80 to 100

#6 Updated by chris.fulton about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF