Project

General

Profile

Bug #21863

Testing contract generating duplicated contract failure right after accepting the contract

Added by MaltYebisu 4 months ago. Updated about 1 month ago.

Status:
Confirmed
Priority:
Low
Assignee:
-
Category:
Gameplay
Target version:
-
Start date:
04/11/2019
% Done:

10%

Version:
Platform:
Linux, OSX, Windows
Expansion:
Core Game
Language:
English (US)
Votes:
Arrow u r green
Arrow d r red

Description

I'm running KSP on macOS 10.14.4

When playing a new career mode game in a fresh install of 1.7.0, a contract failed right after I accepted it. I am not sure if it failed immediately or after a few seconds, because I first noticed it after entering the VAB.

I don't know if this was because the contract had a short deadline or something else.

The contract was for testing the RT-10 "Hammer" Solid Fuel Booster at the Launch Site.
The contract failed message says "Test No situation report available"

Attached are the player.log and a zip with the save game folder.

555-555-0199@example.com
555-555-0199@example.com

Player.log (838 KB) Player.log 555-555-0199@example.com MaltYebisu, 04/11/2019 01:04 PM
Savegame.zip (29.5 KB) Savegame.zip 555-555-0199@example.com MaltYebisu, 04/11/2019 01:05 PM
screenshot0.png (410 KB) screenshot0.png 555-555-0199@example.com MaltYebisu, 04/11/2019 01:08 PM
screenshot1.png (2 MB) screenshot1.png 555-555-0199@example.com MaltYebisu, 04/11/2019 01:08 PM
screenshot1643.png (773 KB) screenshot1643.png Nebbie, 06/06/2019 03:52 AM
screenshot1644.png (781 KB) screenshot1644.png Nebbie, 06/06/2019 03:52 AM
screenshot1645.png (785 KB) screenshot1645.png Nebbie, 06/06/2019 03:52 AM
screenshot1646.png (813 KB) screenshot1646.png Nebbie, 06/06/2019 03:52 AM
Bug_reproduce.zip (21.5 KB) Bug_reproduce.zip SuDmit, 07/18/2019 06:21 AM
screenshot61.png (1.22 MB) screenshot61.png step 5, can see that the contract has normal 1-year duration SuDmit, 07/18/2019 06:22 AM
screenshot62.png (3.32 MB) screenshot62.png step 8 SuDmit, 07/18/2019 06:22 AM
screenshot64.png (4.11 MB) screenshot64.png steps 11-12, also accepted another one SuDmit, 07/18/2019 06:22 AM
45171
45172
47113
47114
47115
47116
47972
47973
47974

History

#1 Updated by Nebbie 3 months ago

47113
47114
47115
47116

I've gotten this as well, it seems like sometimes test contracts generate failures immediately, but are still completable. Both contracts showing failures show identical successes, and I know I only accepted 1 of each. I remember noticing the failure messages on entering the VAB to create the crafts to complete them.

This is happening with both DLCs installed, although I think it's a problem with the core game, don't see how Making History could cause it.

#2 Updated by Nebbie 3 months ago

  • Subject changed from Testing contract failed right after accepting the contract to Testing contract generating duplicated contract failure right after accepting the contract

#3 Updated by SuDmit about 1 month ago

47972
47973
47974

Sorry for possibly bad english, this is not my native language.

I reproduced this bug on Windows 7 x64.
Game version 1.7.3, clean (absolutely no mods) Steam install, no DLC.

Game generates contracts for old variants of reskinned parts (1.7.0 update), hidden from player using parameter category = none and had additional flag TechHidden = true
After these contracts are accepted, probably when scene changes, game checks for TechHidden flag and fails them.

Reproduce steps:
1) for more comfortable search rename old parts' titles in format [OLD] defaultTitle, e.g. [OLD] RT-10 "Hammer" Solid Fuel Booster //#autoLOC...
2a) start new career and complete default "Launch our first vessel!" contract
2b) or just continue existing career
3) decline new offered contracts until getting one with the [OLD] tag
4) accept contract
5) make quicksave (not necessary for reproducing, but useful for further checks)
6) go to VAB, SPH, Tracking Station or just reload quicksave
7) get contract instantly failed

Special check for TechHidden line:
8) exit game
9) comment line //TechHidden = true in old parts' files or set it to the False value
10) start game and load the quicksave created on the 5th step
11) not get contract instantly failed

This contract is still impossible to complete, because of the line category = none, that does not allow part to appear in the Editor. If valid value is set e.g. category = Engine, contract becomes available to perform. Of course that is not needed, there are revamped parts for playing with.

Summary:
Looks like the game doesn't check parts' value TechHidden during contract generation, so that check can be added. An alternative way is to remove MODULE[ModuleTestSubject] from old parts to prevent contract generation for them.

Also available in: Atom PDF