Kerbal Space Program

When initiating a vessel this method copies the root part with all it's modules and contents to the vessel gameObject.

There's an error in the way the fields are copied for both the Part and all PartModule enclosed within.

Currently it looks like this:

Part part = vesselRef.gameObject.AddComponent(this.partRef.GetType()) as Part;
FieldInfo[] fields = this.partRef.GetType().GetFields();
for (int i = 0; i < fields.Length; i++)
{
    FieldInfo fieldInfo = fields[i];
    if (fieldInfo.IsPublic)
    {
        fieldInfo.SetValue(part, fieldInfo.GetValue(this.partRef));
    }
}

Which isn't correct. It will copy static fields, and attempt to copy constant fields too resulting in exceptions. It also misses out on non-public fields which really should get copied.

A much better way would be:

Part part = vesselRef.gameObject.AddComponent(this.partRef.GetType()) as Part;
FieldInfo[] fields = this.partRef.GetType().GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance);
for (int i = 0; i < fields.Length; i++)
{
    FieldInfo fieldInfo = fields[i];
    fieldInfo.SetValue(part, fieldInfo.GetValue(this.partRef));
}

Note this same code block is also used for PartModule as well as Part, so there's two bits to fix.