Project

General

Profile

Bug #18113

Craft naming overwrites file name and can cause craft files to be lost!

Added by xsr71 almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Severity:
Low
Assignee:
TriggerAu
Category:
Gameplay
Target version:
1.4.2
Start date:
03/18/2018
% Done:

100%

Version:
1.4.1
Platform:
Windows
Expansion:
Core Game, Making History
Language:
English (US)
Mod Related:
No
Votes:
Arrow u r green
Arrow d r red

Description

I've lost 2 craft files already when using the new craft naming function. A strange behavior occurs in which the craft name (as defined in parts) can cause the craft file name to be overwritten without you knowing about it.

1. Make a new craft. Name it 'ABC'. Vessel name the priority part 'ABC'.
2. Make a new craft. Name it 'DEF'. Vessel name the priority part 'DEF'.
3. Now, Load 'DEF'. Change the vessel name to 'ABC', but keep the craft file 'DEF'. When you save, it will be saved to 'DEF' as expected.
4. However, if you load 'DEF', the craft file automatically changes to 'ABC'. If you're not careful and save here, you can overwrite 'ABC'!

20180318143439_1.jpg (413 KB) 20180318143439_1.jpg ABC file name and vessel name xsr71, 03/18/2018 05:40 PM
20180318143501_1.jpg (424 KB) 20180318143501_1.jpg DEF file name and vessel name xsr71, 03/18/2018 05:40 PM
20180318143535_1.jpg (412 KB) 20180318143535_1.jpg DEF file name, changed vessel name to ABC xsr71, 03/18/2018 05:41 PM
20180318143552_1.jpg (411 KB) 20180318143552_1.jpg When loading DEF... xsr71, 03/18/2018 05:41 PM
20180318144211_1.jpg (408 KB) 20180318144211_1.jpg .. craft changes file name to ABC! xsr71, 03/18/2018 05:42 PM
34616
34617
34618
34619
34620

History

#1 Updated by TriggerAu almost 7 years ago

  • Status changed from New to Confirmed
  • Assignee set to TriggerAu
  • % Done changed from 0 to 10

Confirmed here - On it

#3 Updated by TriggerAu over 6 years ago

  • Status changed from Confirmed to Ready to Test
  • Target version set to 1.4.2
  • % Done changed from 10 to 80

This one should be fixed in the 1.4.2 patch

#4 Updated by Anth12 over 6 years ago

  • Status changed from Ready to Test to Needs Clarification
  • % Done changed from 80 to 0

GOG 1.2.2 Clean Install
GOG 1.4.1 (core game only) Clean Install
GOG 1.4.3 (core game only) Clean Install

Nearly Fixed but not quite.

So theres another way this can happen.

1. Make a new craft. Name it 'ABC'. Save it.
2. Make a new craft. Name it 'DEF'. Save it.
3. Load DEF. Change the craft to ABC via the new naming system OR by just changing it at the top of the screen.
4. Do not save it.
4. Exit Editor to KSC screen
5. Reenter the Editor and the ABC will stay as the name of the craft.
6. Save it and there will be no warning. It will overwrite ABC and the player will be non the wiser.

Reason this needs clarification is that I can reproduce this bug without any interaction with the new naming system even in 1.2.2.
Perhaps its a completely seperate bug?

#5 Updated by jclovis3 over 6 years ago

  • Status changed from Needs Clarification to Updated
  • % Done changed from 0 to 10

I concur. The VAB remembers the last craft you were editing but doesn't remember if you had changed the name from the time you had loaded it. A good idea would be that upon exiting the VAB, if changes were made, the user would be prompted to discard all changes, or save. Then if they had changed the name, the save would trigger a confirmation of overwrite. The choice to discard all changes should wipe the memory of the last vessel being edited so when you enter, you start with a clean slate and can load your ship to continue working on it.

#6 Updated by TriggerAu over 6 years ago

  • Status changed from Updated to Resolved
  • % Done changed from 10 to 100

Fixeded

#7 Updated by joshua.collins about 6 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF