Project

General

Profile

Bug #6504

Named saves fail to save.when overwriting

Added by neuron over 8 years ago. Updated over 7 years ago.

Status:
Closed
Severity:
Low
Assignee:
-
Category:
Application
Target version:
-
Start date:
01/02/2016
% Done:

100%

Version:
Platform:
Linux
Expansion:
Language:
English (US)
Mod Related:
No
Votes:
Arrow u r green
Arrow d r red

Description

Hi

I've played the game for about 60 hours now. My first game in career I played for 40+ hours, then I lost my savegame.

1. I saved (or atleast thought I did)
2. Loaded, realized the load had loaded a game which was very old and not the one I thought I saved.
3. Tried to load again, but realized I had no recent game and my persistant world was overwritten.
4. Immediately threw away the game and haven't touched it for 6 months.

(I have continous differential backups running, but since KSP saves everything in the steamapps directory it doesn't catch them. As that directory has game files only for every other game..)

Now this happened again. I saved on "Save1", loaded, Save1 was definately not recent, and that overwrote my persistant world.

This has made me throw away the game after spending another 10+ hours on it, frankly this is the kind of bug that should never never be possible. Anything leading up to it could be a user error (although I doubt it and I do think there is a bug in saving somewhere..). BUT it's very easily solvable by autosaving the game and rotating the savegames. That should be minimal work.

I've been a software dev for about 15 years and I wouldn't generally mark a bug as critical in someone elses bugtracker, but this is in my opinion the absolutely worst kind of bug possible... :/


Related issues

Related to Kerbal Space Program - Bug #5354: Roles of Escape and Enter switched in quicksave dialogDuplicate08/28/2015

History

#1 Updated by neuron over 8 years ago

(Note that in my recent "I saved on save1" there was already a savegame existing with that name. Maybe I wrote save1 and Save1 already existed and that screws up on linux or something.. I dont know, it could be PEBCAK as well of course, but I just dont see how I screwed it up. Especially twice).

#2 Updated by Skrudland over 8 years ago

Exact same problem here. I've lost at least a week's worth of work three times now. Frustrating as hell.

After the first couple of times it happened I got into the habit of saving every time I did anything at all. Today I must have manually saved on my "Skrud" savegame at least five times, and then when I try to load, it takes me way back in time. I checked the savegame folder in steamapps, and it's saying my "Skrud" savegame was last modified ten days ago.

#3 Updated by Squelch about 8 years ago

  • Tracker changed from Bug to Feedback
  • Severity changed from Critical to Low

Thank you for your report. However, it does not meet the requirements for a critical priority. Please read our Guide for details on how to report an issue, and what the priorities mean.

As a developer, I'm sure you will appreciate the need for specifics when reporting a bug. These are sadly lacking here. Again, please refer to our guide.

The expected behaviour, if I'm correct in interpreting the report, is that when saving a game, that this will automatically be loaded when resuming again later?

The actual behaviour is thus:

  • A persistence file is created at the start of a game.
  • Auto saves are periodically written to persistence.
  • A change of scene (eg going from Tracking Station to flight) or other significant change to the game state will also write to persistence.
  • The persistence file is loaded when resuming a game.
  • A quicksave creates a snapshot.
  • Quicksaves are made pressing F5.
  • A second quicksave overwrites the existing quicksave.
  • Loading a quicksave is performed by pressing F9 for a few seconds.
  • Quick saves do not overwrite persistence file, but the next autosave will.
  • Quick saves are not auto loaded.
  • Named saves also create a snapshot.
  • These can be made from the KSC esc menu or by pressing mod+F5 key combination.
  • These saves can be named, and have a suggested name of quicksave + an increment (quicksave1 etc)
  • Loading a named save is performed using the mod+F9 key combination. Any save can be loaded from this menu, including the persistence file. This can also be performed from the KSC esc menu.
  • Named saves do not overwrite the persistence file, but the next autosave will.
  • Named saves are not auto loaded.

The persistence file is not versioned or incremented. It is a record of the entire world state at the current time (persistence defined)
Quicksaves are unique snapshots of the persistence at a particular time. Loading them will roll back to that time. My understanding of the report is that this is expected to be automatic.

It is unfortunate that you felt it necessary to throw games away, but the ability to preserve the game is available at any time, and furthermore can be restored to that state at any time. The persistence file is the only file that is loaded when resuming a game.

It is conceded that the save mechanism is not well documented, nor particularly intuitive, so as a result I have changed this issue to feedback. The alternative is to mark it as not a bug when the detailed explanation of the behaviour is considered.

Please be assured that steps are being made to improve the user experience of the save and load system.

[Addendum]

Case sensitivity is noted as having caused issues on Linux and OSX.

#4 Updated by Skrudland about 8 years ago

I think you didn't quite understand what neuron and myself were saying. It's nothing to do with problems with the autosave, it's to do with the named saves. I'm manually saving on a named save file, and then when I go to load said save file, it hasn't been saved and I've lost weeks of progress.

This is most definitely a bug.

#5 Updated by Squelch about 8 years ago

Thanks for the clarification. The ambiguous description and especially the title "autosave" led to deceive. I will also admit to some confirmation bias on my part as I was searching for savegame related issues, particularly around autosave user experience. Specifics would help greatly here.

My understanding now, is that a named save is not actually being saved, so the loading of another save is effectively leaving persistence in an unwanted state?

A detailed recipe for reproduction would be most helpful in cases like this. If a named save is failing, then a copy of the logs would aid in identifying why this would be.

If someone would be so kind as to provide further clarification and provide detailed steps for reproduction, we can look into this? A title change for this issue is probably warranted once the nature of the problem is clear.

#6 Updated by neuron about 8 years ago

Both times this has failed for me I've tried to save over an existing savegame. I haven't gotten an error or anything like that, but it just hasn't updated the file. Therefor I assume everything is well, but So when I load the game again it's an ancient one.

This also overwrites the persistant world state, so I have no way to recover.

#7 Updated by Squelch about 8 years ago

  • Tracker changed from Feedback to Bug
  • Subject changed from autosave to Named saves fail to save.when overwriting
  • Status changed from New to Need More Info

neuron wrote:

Both times this has failed for me I've tried to save over an existing savegame. I haven't gotten an error or anything like that, but it just hasn't updated the file. Therefor I assume everything is well, but So when I load the game again it's an ancient one.

This also overwrites the persistant world state, so I have no way to recover.

Thanks. The persistence will be updated, and this is by design. However, if a named save is not saving, then it is most certainly a bug.

A copy of the named save affected, together with copies of the logs that cover the attempt to overwrite can tell us a lot about what might be going wrong. Does saving under a different name work correctly for that particular save? If so, please attach both the original and the new save? Again, logs of the event are most useful.

Disregarding the autosave behaviour which sounds like it is working as designed, the failing to overwrite needs attention, but we really do need to get an understanding on why this is happening under some circumstances.

#8 Updated by Squelch about 8 years ago

  • Related to Bug #5354: Roles of Escape and Enter switched in quicksave dialog added

#9 Updated by Squelch about 8 years ago

I suspect that this might be a variation on the save dialog being dismissed when the "Enter" key is used. see issue #5354.

#10 Updated by Kasuha about 8 years ago

I just tested it on my 1.0.5 KSP and I can confirm that overwriting named saves works for me.

Made a named save "Save1", tested that it loads
Switched to a different ship, made another named save "Save1", timestamp of the Save1.sfs updated and after I loaded it, I was on the second ship.
Then I switched to Space Center, made another named save "Save1" through the menu, again the file timestamp changed. Then I went to a ship, loaded "Save1" through Alt+F9 and the game loaded it and switched me to an asteroid (#6337)

I used mouse to click on all buttons.

It should probably warn me when I'm overwriting an existing save though.

And it would be really great if the game gave me a list of already existing saves when I am creating a new one - either so I can avoid a name collision, or so I can intentionally use the same name again, or so that I can simply create another one in a consistent manner, I like to make numbered named saves: 00-launch, 01-orbit, 02-transfer burn, etc - but it's hard to remember last used number if I can't see them.

#11 Updated by Kasuha about 8 years ago

Correction to my previous entry: I'm sorry, I did not notice the issue is about Linux. My test was on Windows, therefore not applicable to Linux issue.

#12 Updated by Skrudland about 8 years ago

I'm having the same problem on Windows.

And it doesn't happen every time, just sometimes.

#13 Updated by TriggerAu almost 8 years ago

  • Status changed from Need More Info to Needs Clarification

#14 Updated by sal_vager over 7 years ago

  • Status changed from Needs Clarification to Ready to Test
  • % Done changed from 0 to 80

The actions of the enter and escape key are fixed now so this should no longer occur.

#15 Updated by JPLRepo over 7 years ago

  • Status changed from Ready to Test to Closed
  • % Done changed from 80 to 100

Closing. No response.

Also available in: Atom PDF