Project

General

Profile

Bug #28569

ModuleInventoryPart in ProtoCrewMember aren't added to the KerbalInventoryScenario, causing various issues

Added by gotmachine about 3 years ago. Updated almost 3 years ago.

Status:
New
Severity:
Low
Assignee:
-
Category:
Kerbals
Target version:
-
Start date:
10/26/2021
% Done:

0%

Version:
Platform:
Linux, OSX, Windows
Expansion:
Core Game
Language:
English (US)
Mod Related:
No
Votes:
Arrow u r green
Arrow d r red

Description

KerbalInventoryScenario is supposed to handle the ModuleInventoryPart instances created for in-vessel crew members through the ProtoCrewMember.kerbalModule getter.
However, at least in 1.12.2, the getter will bail out from adding those inventory instances to the KerbalInventoryScenario instance, unless the current game mode is SCENARIO or SCENARIO_NON_RESUMABLE.
I guess the conditions where inverted by mistake, although I fail to understand why there should be any condition of that type.

This cause ModuleInventoryPart.Update() to not run for kerbal inventories, which lead to the inventory not being updated when hovering them with a held part. The volume/mass limit sliders don't update, and the player can effectively entirely bypass the limits.

This also cause the whole kerbal inventory persistence system to fail in various ways, this is responsible for those two issues :
https://bugs.kerbalspaceprogram.com/issues/28559
https://bugs.kerbalspaceprogram.com/issues/28561

History

#1 Updated by Kermak almost 3 years ago

I think I met the same problem in version 1.12.3 (with DLC Making History and Breaking Ground).
Link on the youtube video:
https://youtu.be/Pgby3RoOpDg

Also available in: Atom PDF