https://bugs.kerbalspaceprogram.com/https://bugs.kerbalspaceprogram.com/favicon.ico?15601711372021-01-02T22:07:54ZSquad BugtrackerKerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1583312021-01-02T22:07:54ZDunbaratu
<ul><li><strong>Subject</strong> changed from <i>Contract Duration too short when an interplanetary transfer window is needed.</i> to <i>New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)</i></li></ul> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1583322021-01-02T22:14:01ZDunbaratu
<ul><li><strong>File</strong> <a href="/attachments/55558/screenshot12.png">screenshot12.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/55558/screenshot12.png">screenshot12.png</a> added</li><li><strong>File</strong> <a href="/attachments/55559/screenshot13.png">screenshot13.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/55559/screenshot13.png">screenshot13.png</a> added</li></ul><p>Further investigation seems to indicate that the problem is specific to just the <strong>new KSP 1.11 contracts</strong>. They have one hardcoded duration and are always exactly 2 years no matter where they're located. Repair something around Kerbin? 2 years. Repair something around Duna? 2 years. Repair something around Jool? 2 years. It's not varying the duration based on the sphere of influence at all. For other contracts it seems to throw in a multiplication by the recoveryValue for the planet it's at, but nothing like that seems to be happening for these new contracts.</p>
<p>I am attaching screen shots with an example about a rover repair contract. The two screen shots are a "before taking contract" and "after taking contract" picture.</p> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1583332021-01-02T22:58:39ZPoodmundeddieturner2002@gmail.com
<ul></ul><p>I think all 3 of the new contract types: RoverConstruction, OrbitalConstruction and VesselRepair are affected here because they are not allowing for the contract's targetBody to be specified, its just being set as null so therefore the DeadlineDays length is never being weighted relative to the scienceValues.RecoveryValues for the body the contract is specified for.</p>
<p>As an aside, the OrbitalConstruction contract definition looks like it is also incorrectly using values from the class RoverConstruction for all the contract parameters rather than from its own OrbitalConstruction class...</p> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1583342021-01-02T22:59:39ZPoodmundeddieturner2002@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>10</i></li></ul> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1583392021-01-03T17:50:47ZNeilski
<ul></ul><p>The OrbitalConstructionContract missions are also on the short side: I was offered an Eve contract (to add a part to a satellite) with 1y218d until expiry, which is way too short to wait for a transfer window.</p> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1583412021-01-03T20:15:29ZPoodmundeddieturner2002@gmail.com
<ul></ul><p>Neilski wrote:</p>
<blockquote>
<p>The OrbitalConstructionContract missions are also on the short side: I was offered an Eve contract (to add a part to a satellite) with 1y218d until expiry, which is way too short to wait for a transfer window.</p>
</blockquote>
<p>This is because the contract weighting for these 3 contract types is 852 (as specified in Contracts.cfg)... 852 / 426 (426 days in a Kerbal year) = 2 years. If this bug gets resolved an Eve contract of this type would be bumped up to 10 years.</p> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1589822021-01-13T22:22:48ZNeilski
<ul></ul><p>Poodmund wrote:</p>
<blockquote>
<p>Neilski wrote:</p>
<blockquote>
<p>The OrbitalConstructionContract missions are also on the short side: I was offered an Eve contract (to add a part to a satellite) with 1y218d until expiry, which is way too short to wait for a transfer window.</p>
</blockquote>
<p>This is because the contract weighting for these 3 contract types is 852 (as specified in Contracts.cfg)... 852 / 426 (426 days in a Kerbal year) = 2 years. If this bug gets resolved an Eve contract of this type would be bumped up to 10 years.</p>
</blockquote>
<p>Well, I don't understand how a 2-year contract could reach 1y218d before I accepted it - usually contracts only stay on offer for a few days, no?</p> Kerbal Space Program - Bug #26958: New KSP 1.11 repair contracts give too-short durations (ignoring the modifier for what body it's at)https://bugs.kerbalspaceprogram.com/issues/26958?journal_id=1677602021-06-24T22:35:12Zvictorr
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Ready to Test</i></li><li><strong>Target version</strong> set to <i>1.12.0</i></li><li><strong>% Done</strong> changed from <i>10</i> to <i>80</i></li></ul><p>We have made some changes in this last 1.12.0 release and would like some feedback on this issue. Thanks.</p>