Project

General

Profile

Bug #18605

Incorrect part variant config for FL-TX440 (Size1p5_Tank_02)

Added by cake-pie about 3 years ago. Updated almost 3 years ago.

Status:
Investigating
Severity:
Low
Assignee:
-
Category:
Camera
Target version:
Start date:
04/18/2018
% Done:

20%

Version:
Platform:
Linux, OSX, Windows
Expansion:
Making History
Language:
Mod Related:
No
Votes:
Arrow u r green
Arrow d r red

Description

The FL-TX440 Fuel Tank has incorrect part variant config (Size1p5_Tank_02.cfg)

The other related tanks (FL-TX220 / 900 / 1800) have identical part variant config, as follows:

    MODULE
    {
        name = ModulePartVariants
        primaryColor = #ffffff
        secondaryColor = #000000
        baseDisplayName = #autoLOC_8007119
        baseThemeName = White
        VARIANT
        {
            name = Grey
            displayName = #autoLOC_8007120
            themeName = BlackAndWhite
            primaryColor = #000000
            secondaryColor = #ffffff
            TEXTURE
            {
                mainTextureURL = SquadExpansion/MakingHistory/Parts/FuelTank/Assets/Size1_5_Tanks_grey    
            }
        }
        VARIANT
        {
            name = Dark Grey
            displayName = #autoLOC_8007121
            themeName = GrayAndOrange
            primaryColor = #4c4f47
            secondaryColor = #f49841
            TEXTURE
            {
                shader = KSP/Bumped Specular
                mainTextureURL = SquadExpansion/MakingHistory/Parts/FuelTank/Assets/Size1_5_Tanks_ALT02
                _BumpMap = SquadExpansion/MakingHistory/Parts/FuelTank/Assets/Size1_5_Tanks_ALT02_nm
            }
        }
    }

Whereas FL-TX440 has the "White" and "BlackAndWhite" themes reversed:

    MODULE
    {
        name = ModulePartVariants
        primaryColor = #ffffff
        secondaryColor = #000000
        baseDisplayName = #autoLOC_8007120
        baseThemeName = BlackAndWhite
        VARIANT
        {
            name = White
            displayName = #autoLOC_8007119
            themeName = White
            primaryColor = #ffffff
            secondaryColor = #eeeeee
            TEXTURE
            {
                mainTextureURL = SquadExpansion/MakingHistory/Parts/FuelTank/Assets/Size1_5_Tanks_grey
            }
        }
        VARIANT
        {
            name = Dark Grey
            displayName = #autoLOC_8007121
            themeName = GrayAndOrange
            primaryColor = #4c4f47
            secondaryColor = #f49841
            TEXTURE
            {
                shader = KSP/Bumped Specular
                mainTextureURL = SquadExpansion/MakingHistory/Parts/FuelTank/Assets/Size1_5_Tanks_ALT02
                _BumpMap = SquadExpansion/MakingHistory/Parts/FuelTank/Assets/Size1_5_Tanks_ALT02_nm
            }
        }
    }

The mistake is evident in a visual comparison:
screenshot8 eses "White" theme, note the FL-TX220 and FL-TX1800 have the checkered pattern in this theme
screenshot9 uses "BlackAndWhite" theme, FL-TX440 has checkered pattern here and looks out of place.

screenshot11 and screenshot12 show the part variants when matched correctly.

screenshot8.png (1.3 MB) screenshot8.png "White" theme cake-pie, 04/18/2018 12:28 PM
screenshot9.png (1.3 MB) screenshot9.png "BlackAndWhite" theme cake-pie, 04/18/2018 12:28 PM
screenshot12.png (1.21 MB) screenshot12.png "BlackAndWhite" theme w/ FL-TX440 on "White" theme cake-pie, 04/18/2018 12:36 PM
screenshot11.png (1.21 MB) screenshot11.png "White" theme w/ FL-TX440 on "BlackAndWhite" theme cake-pie, 04/18/2018 12:36 PM
screenshot0.png (1.21 MB) screenshot0.png Initial state cake-pie, 04/30/2018 07:13 AM
screenshot1.png (1.2 MB) screenshot1.png "White" applied to whole vessel cake-pie, 04/30/2018 07:13 AM
screenshot2.png (1.2 MB) screenshot2.png "Black and White" applied to whole vessel cake-pie, 04/30/2018 07:13 AM
35517
35518
35519
35520
35857
35858
35859

History

#2 Updated by Squelch about 3 years ago

  • Status changed from New to Ready to Test
  • Target version set to 1.4.3
  • % Done changed from 0 to 80

The variants have been corrected now. White = White, Black and white...

#3 Updated by cake-pie about 3 years ago

35857
35858
35859

No, this has not been fixed.

Tested with MHE-v1.2en-us installed on top of KSP 1.4.3 build 02152

#4 Updated by Squelch about 3 years ago

  • Status changed from Not Fixed to Investigating
  • % Done changed from 50 to 20

#5 Updated by klesh about 3 years ago

Confirmed not fixed in 1.4.3

#6 Updated by cake-pie almost 3 years ago

Not fixed in 1.4.4

Also available in: Atom PDF