Project

General

Profile

Bug #13194

Incorrect variable values in CommLink instances

Added by TaxiService almost 3 years ago. Updated almost 3 years ago.

Status:
Updated
Priority:
Normal
Assignee:
Category:
Gameplay
Target version:
-
Start date:
11/06/2016
% Done:

10%

Version:
Platform:
Windows
Expansion:
Language:
English (US)
Votes:
Arrow u r green
Arrow d r red

Description

Stock KSP 1.2.1 64-bit & 32-bit, clean installed, resided outside Steam for mod development.
Mods: an optional demonstration DLL to read CommLink values (attached Simple.cs)

What happened:
All of the CommLink instances in CommNetNetwork.Instance.CommNet.Links have two incorrect values of the signalStrength and hopType variables. (attached incorrect_values.png)

Reproduction steps (in a debug mode):
1) Launch KSP and create a new save (preferably, Sandbox)
2) Build a direct antenna and some solar panels on a probe in VAB (attached craft.png)
3) Launch and inspect the particular variables mentioned

Expected results:
1) signalStrength variable is in [0.0, 1.0]
2) hopType variable is HopType.Home (the direct antenna to KSC)

Actual results:
1) signalStrength variable exceeds 1.0, almost matched to the cost variable
2) hopType variable is HopType.Relay (always HopType.Relay)

Extra details:
1) I can't reproduce this reliably but the cost variable of a CommLink instance is sometimes zero despite the visible distance is non-trivial.

incorrect_values.png (155 KB) incorrect_values.png 555-555-0199@example.com TaxiService, 11/06/2016 07:14 AM
output_log.txt (1.37 MB) output_log.txt 555-555-0199@example.com TaxiService, 11/06/2016 07:14 AM
Simple.cs (862 Bytes) Simple.cs 555-555-0199@example.com TaxiService, 11/06/2016 07:14 AM
craft.png (1.92 MB) craft.png 555-555-0199@example.com TaxiService, 11/06/2016 07:14 AM
25803
25806

History

#1 Updated by sal_vager almost 3 years ago

  • Status changed from New to Need More Info

Hello TaxiService, can you demonstrate any negative effect in-game from these variables?

#2 Updated by TaxiService almost 3 years ago

No, there are no negative visible effects from these variables in the stock playing.

Obviously, the negative effect of accessing these variables directly is the incorrect information requested for a CommNet-related add-on.

#3 Updated by sal_vager almost 3 years ago

  • Status changed from Need More Info to Updated
  • Assignee set to RoverDude
  • % Done changed from 0 to 10

I see, thanks for the update, Roverdude is still responsible for commnet so I'll get him on this.

Also available in: Atom PDF