Kerbal Space Program

Looking for a way to change the display name (green label above the text generated by GetInfo()) of my part module I discovered that KSPModule attribute was apparently designed to do that.
However it does not have any effect thanks to a bug in PartModule.ReflectedAttributes constructor where kspModules field is not populated correctly resulting in PartModule.ModularSetup() ignoring the module name from KSPModule and always using the class name to derive the display name of the module.

Bug seems to be caused by this line:

  kspModules = (KSPModule[])moduleType.GetType().GetCustomAttributes(typeof(KSPModule), true);

which should be corrected to:

  kspModules = (KSPModule[])moduleType.GetCustomAttributes(typeof(KSPModule), true);

because moduleType already refers to the class

Notes:

• PartModule.GUIName is not virtual, so it cannot be overriden.
• There is no other way to change the private field used by PartModule.GUIName
• other fields/properties with "name" in them have different use.
• This does not look like intentionally disabled. There are cleaner (and clearer) ways.
• This has practically no impact even for moddes. It's just something that is broken and trivial to fix.